Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: cli should not split args by comma for env/labels #2171

Merged
merged 1 commit into from
Aug 30, 2018
Merged

bugfix: cli should not split args by comma for env/labels #2171

merged 1 commit into from
Aug 30, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Aug 29, 2018

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

flagset.StringSlice will split args by comma so that the env/labels
parse job fails. Should use StringArray for env/labels.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

already added it.

Ⅳ. Describe how to verify it

CI

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Aug 29, 2018
bugfix: cli should not split args by comma for env/labels
edff9b8 
flagset.StringSlice will split args by comma so that the env/labels
parse job fails. Should use StringArray for env/labels.

Signed-off-by: Wei Fu <fhfuwei@163.com>
@codecov-io
Copy link

Codecov Report

Merging #2171 into master will increase coverage by 12.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2171       +/-   ##
===========================================
+ Coverage   51.22%   64.04%   +12.82%     
===========================================
  Files         209      209               
  Lines       16725    16904      +179     
===========================================
+ Hits         8567    10827     +2260     
+ Misses       7150     4735     -2415     
- Partials     1008     1342      +334
Flag Coverage Δ
#criv1alpha1test 32.9% <ø> (?)
#criv1alpha2test 33.58% <ø> (?)
#integrationtest 39.25% <ø> (ø) ⬆️
#unittest 23.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/image.go 75% <0%> (-2.2%) ⬇️
ctrd/container.go 40.48% <0%> (-1.29%) ⬇️
daemon/mgr/container_storage.go 50.93% <0%> (+0.46%) ⬆️
pkg/utils/utils.go 84.3% <0%> (+0.58%) ⬆️
daemon/mgr/container_types.go 83.63% <0%> (+2.72%) ⬆️
daemon/config/config.go 44.28% <0%> (+2.85%) ⬆️
daemon/mgr/container_utils.go 84.33% <0%> (+3.01%) ⬆️
pkg/meta/local.go 63.91% <0%> (+3.09%) ⬆️
daemon/mgr/container.go 56.98% <0%> (+3.28%) ⬆️
pkg/user/user.go 40% <0%> (+3.33%) ⬆️
... and 39 more

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 30, 2018
@allencloud allencloud merged commit f27e5c0 into AliyunContainerService:master Aug 30, 2018
@fuweid fuweid deleted the bugfix_support_comma_in_env_and_label branch August 31, 2018 11:47
@pouchrobot pouchrobot mentioned this pull request Sep 1, 2018
Closed
@wangforthinker wangforthinker mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuweid @codecov-io @allencloud @pouchrobot